Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Contributors to README #36

Merged
merged 1 commit into from
Jan 18, 2018
Merged

Add Contributors to README #36

merged 1 commit into from
Jan 18, 2018

Conversation

taveras
Copy link
Contributor

@taveras taveras commented Jan 18, 2018

Description

This change adds a link to view the contributors for the project.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore, documentation, cleanup

Related Issue

#23

Checklist:

  • My code follows the code style of this project.
  • I have updated the documentation (if required).
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@taveras
Copy link
Contributor Author

taveras commented Jan 18, 2018

@gautamarora does this seem good for our README, or should we do similar to our package.json and list each contributor?

i'm fine with taking either approach

@gautamarora gautamarora mentioned this pull request Jan 18, 2018
Open
28 tasks
@gautamarora
Copy link
Contributor

This looks good to me for now, I can work on adding something like this for this for our projects later: https://github.com/paypal/glamorous#contributors

It will require adding a npm command that can automatically handle adding contributors.

pgoldrbx
pgoldrbx reviewed Jan 18, 2018
View reviewed changes
Copy link
Contributor

@pgoldrbx pgoldrbx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤷‍♂️ sure

@taveras
Copy link
Contributor Author

taveras commented Jan 18, 2018

:shipit:

@taveras taveras merged commit e8a4c6e into master Jan 18, 2018
@taveras taveras deleted the doc/contributors branch January 18, 2018 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gautamarora gautamarora gautamarora approved these changes

@pgoldrbx pgoldrbx pgoldrbx approved these changes

Assignees
No one assigned
Labels
documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@taveras @gautamarora @pgoldrbx